1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
|
package importer
import (
"os"
"path/filepath"
"strings"
"testing"
"adammathes.com/neko/config"
"adammathes.com/neko/models"
)
func setupTestDB(t *testing.T) {
t.Helper()
config.Config.DBFile = filepath.Join(t.TempDir(), "test.db")
models.InitDB()
t.Cleanup(func() {
if models.DB != nil {
models.DB.Close()
}
})
}
func TestInsertIItem(t *testing.T) {
setupTestDB(t)
ii := &IItem{
Title: "Test Article",
Url: "https://example.com/article",
Description: "A test article description",
ReadState: false,
Starred: true,
Date: &IDate{Date: "2024-01-15 10:00:00"},
Feed: &IFeed{
Url: "https://example.com/feed",
Title: "Example Feed",
},
}
InsertIItem(ii)
// Verify the feed was created
var feedCount int
models.DB.QueryRow("SELECT COUNT(*) FROM feed").Scan(&feedCount)
if feedCount != 1 {
t.Errorf("Expected 1 feed, got %d", feedCount)
}
// Verify the item was created
var itemCount int
models.DB.QueryRow("SELECT COUNT(*) FROM item").Scan(&itemCount)
if itemCount != 1 {
t.Errorf("Expected 1 item, got %d", itemCount)
}
}
func TestInsertIItemNilFeed(t *testing.T) {
setupTestDB(t)
ii := &IItem{
Title: "No Feed Item",
Url: "https://example.com/nofeed",
Feed: nil,
}
// Should not panic
InsertIItem(ii)
var itemCount int
models.DB.QueryRow("SELECT COUNT(*) FROM item").Scan(&itemCount)
if itemCount != 0 {
t.Errorf("Expected 0 items (nil feed should be skipped), got %d", itemCount)
}
}
func TestInsertIItemExistingFeed(t *testing.T) {
setupTestDB(t)
// Insert feed first
models.DB.Exec("INSERT INTO feed(url, title) VALUES(?, ?)", "https://example.com/feed", "Existing Feed")
ii := &IItem{
Title: "New Article",
Url: "https://example.com/new-article",
Description: "New article desc",
Date: &IDate{Date: "2024-01-15"},
Feed: &IFeed{
Url: "https://example.com/feed",
Title: "Existing Feed",
},
}
InsertIItem(ii)
// Should still be just 1 feed
var feedCount int
models.DB.QueryRow("SELECT COUNT(*) FROM feed").Scan(&feedCount)
if feedCount != 1 {
t.Errorf("Expected 1 feed (reuse existing), got %d", feedCount)
}
}
func TestImportJSON(t *testing.T) {
setupTestDB(t)
dir := t.TempDir()
jsonFile := filepath.Join(dir, "import.json")
content := `{"title":"Article 1","url":"https://example.com/1","description":"desc1","read":false,"starred":false,"date":{"$date":"2024-01-01"},"feed":{"url":"https://example.com/feed","title":"Feed 1"}}
{"title":"Article 2","url":"https://example.com/2","description":"desc2","read":true,"starred":true,"date":{"$date":"2024-01-02"},"feed":{"url":"https://example.com/feed","title":"Feed 1"}}`
err := os.WriteFile(jsonFile, []byte(content), 0644)
if err != nil {
t.Fatal(err)
}
ImportJSON(jsonFile)
var itemCount int
models.DB.QueryRow("SELECT COUNT(*) FROM item").Scan(&itemCount)
if itemCount != 2 {
t.Errorf("Expected 2 items after import, got %d", itemCount)
}
var feedCount int
models.DB.QueryRow("SELECT COUNT(*) FROM feed").Scan(&feedCount)
if feedCount != 1 {
t.Errorf("Expected 1 feed after import, got %d", feedCount)
}
}
func TestImportJSONInvalid(t *testing.T) {
setupTestDB(t)
dir := t.TempDir()
jsonFile := filepath.Join(dir, "invalid.json")
os.WriteFile(jsonFile, []byte("not json"), 0644)
err := ImportJSON(jsonFile)
if err == nil {
t.Error("ImportJSON should error on invalid JSON")
}
}
func TestImportJSONNonexistent(t *testing.T) {
setupTestDB(t)
err := ImportJSON("/nonexistent/file.json")
if err == nil {
t.Error("ImportJSON should error on nonexistent file")
}
}
// Test the ImportFeeds dispatcher function (previously 0% coverage)
func TestImportFeedsOPML(t *testing.T) {
setupTestDB(t)
opml := `<?xml version="1.0" encoding="UTF-8"?>
<opml version="2.0">
<head><title>test</title></head>
<body>
<outline type="rss" text="Feed A" xmlUrl="https://a.com/feed" htmlUrl="https://a.com"/>
</body>
</opml>`
err := ImportFeeds("opml", strings.NewReader(opml))
if err != nil {
t.Fatalf("ImportFeeds(opml) failed: %v", err)
}
var count int
models.DB.QueryRow("SELECT COUNT(*) FROM feed").Scan(&count)
if count != 1 {
t.Errorf("expected 1 feed, got %d", count)
}
}
func TestImportFeedsText(t *testing.T) {
setupTestDB(t)
text := "https://example.com/feed1\nhttps://example.com/feed2\n"
err := ImportFeeds("text", strings.NewReader(text))
if err != nil {
t.Fatalf("ImportFeeds(text) failed: %v", err)
}
var count int
models.DB.QueryRow("SELECT COUNT(*) FROM feed").Scan(&count)
if count != 2 {
t.Errorf("expected 2 feeds, got %d", count)
}
}
func TestImportFeedsJSON(t *testing.T) {
setupTestDB(t)
jsonContent := `{"title":"A1","url":"https://example.com/1","description":"d","feed":{"url":"https://example.com/feed","title":"F1"}}`
err := ImportFeeds("json", strings.NewReader(jsonContent))
if err != nil {
t.Fatalf("ImportFeeds(json) failed: %v", err)
}
var count int
models.DB.QueryRow("SELECT COUNT(*) FROM item").Scan(&count)
if count != 1 {
t.Errorf("expected 1 item, got %d", count)
}
}
func TestImportFeedsUnsupported(t *testing.T) {
err := ImportFeeds("csv", strings.NewReader("data"))
if err == nil {
t.Error("ImportFeeds should error for unsupported format")
}
if err != nil && !strings.Contains(err.Error(), "unsupported") {
t.Errorf("expected 'unsupported' error, got: %v", err)
}
}
func TestImportOPMLInvalid(t *testing.T) {
setupTestDB(t)
err := ImportOPML(strings.NewReader("not valid xml"))
if err == nil {
t.Error("ImportOPML should error on invalid XML")
}
}
func TestImportOPMLNestedCategories(t *testing.T) {
setupTestDB(t)
opml := `<?xml version="1.0" encoding="UTF-8"?>
<opml version="2.0">
<head><title>test</title></head>
<body>
<outline text="Tech">
<outline text="Programming">
<outline type="rss" text="Blog A" xmlUrl="https://a.com/feed" htmlUrl="https://a.com"/>
</outline>
</outline>
<outline type="rss" xmlUrl="https://b.com/feed" htmlUrl="https://b.com" category="news"/>
</body>
</opml>`
err := ImportOPML(strings.NewReader(opml))
if err != nil {
t.Fatalf("ImportOPML failed: %v", err)
}
var count int
models.DB.QueryRow("SELECT COUNT(*) FROM feed").Scan(&count)
if count != 2 {
t.Errorf("expected 2 feeds, got %d", count)
}
// Verify nested category is inherited
var category string
models.DB.QueryRow("SELECT category FROM feed WHERE url=?", "https://a.com/feed").Scan(&category)
if category != "Programming" {
t.Errorf("expected category 'Programming' for nested feed, got %q", category)
}
// Feed with category attribute
models.DB.QueryRow("SELECT category FROM feed WHERE url=?", "https://b.com/feed").Scan(&category)
if category != "news" {
t.Errorf("expected category 'news' for feed with category attr, got %q", category)
}
}
func TestInsertIItemNilDate(t *testing.T) {
setupTestDB(t)
ii := &IItem{
Title: "No Date Article",
Url: "https://example.com/nodate",
Description: "Article without date",
Date: nil,
Feed: &IFeed{
Url: "https://example.com/feed",
Title: "Test Feed",
},
}
err := InsertIItem(ii)
if err != nil {
t.Errorf("InsertIItem with nil date should not error, got %v", err)
}
var count int
models.DB.QueryRow("SELECT COUNT(*) FROM item").Scan(&count)
if count != 1 {
t.Errorf("expected 1 item, got %d", count)
}
}
func TestImportJSONReaderEmpty(t *testing.T) {
setupTestDB(t)
// Empty reader - should not error (just EOF immediately)
err := ImportJSONReader(strings.NewReader(""))
if err != nil {
t.Errorf("ImportJSONReader with empty input should not error, got %v", err)
}
}
func TestImportTextSkipsCommentsAndBlanks(t *testing.T) {
setupTestDB(t)
text := `
# This is a comment
https://example.com/feed1
# Another comment
https://example.com/feed2
`
err := ImportText(strings.NewReader(text))
if err != nil {
t.Fatalf("ImportText failed: %v", err)
}
var count int
models.DB.QueryRow("SELECT COUNT(*) FROM feed").Scan(&count)
if count != 2 {
t.Errorf("expected 2 feeds (comments and blanks skipped), got %d", count)
}
}
|
